Fix a couple of minor demo game bugs.#5762
Open
Janzert wants to merge 2 commits intoTextualize:mainfrom
Open
Conversation
Author
|
Found one other bug where creating a new game would create the puzzle with a solution having the blank tile in whatever position the blank happened to be when creating it. |
Janzert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed while playing with the demo app that the sliding puzzle game didn't seem to recognize a correctly solved puzzle. It seemed to be 'one off', where it wanted the blank tile in the bottom right corner but the content for that corner was actually in one of the two adjacent tiles. After much too long investigating, but happily learning a bit about textual in the process, I finally found the content was getting set incorrectly because it was using the tile current position to set the content, but the tile had already moved once in the initial shuffle.
The fix is quite simple using
Tile.start_position, instead ofTile.positionwhen setting the tile's scroll position.Checklist